Fix issue #47 #48
Closed
Fix issue #47 #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| /** | ||
| * Slimmed down version of https://developer.android.com/reference/android/text/TextUtils.html to | ||
| * avoid depending on android.text.TextUtils. |
There was a problem hiding this comment.
Why delete this now? As the comment here shows, we had explicitly decided not to use android.text.TextUtils. Has something changed here?
|
I think this PR is premature; there isn't any agreement on taking this approach. Further, the TextUtils change seems entirely unwarranted - not to mention, unrelated to the issue. Same for the dependency changes. We should try to be disciplined about keeping unrelated changes separated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#47
This exposes libraryloader, libraryinstaller so they can be overridden as needed.
Updates android gradle and compiler dependencies to latest ones